Skip to content

Commit

Permalink
Comment changes
Browse files Browse the repository at this point in the history
  • Loading branch information
parag-pv committed Oct 3, 2024
1 parent 1f0e075 commit 8741ea4
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/sdks/core/src/cpp/sdk/cpptest/unit/accessibilityTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,8 @@ TEST_F(AccessibilityTest, subscribeOnClosedCaptionsSettingsChanged)
Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribe(closedCaptionsChange, &error);
std::cout << " error: " << static_cast<int>(error) << std::endl;
EXPECT_EQ(error, Firebolt::Error::None);
/* We could optionally return a response inside WaitForEventResponse using JSON engine's mockResponse
pointing to #/x-schemas/Types/ListenResponse dereferenced to "{listening:true}".
Since there is no return value for event subscription, error would be the only validation for now.
This is until event response is returned by changing closedCaptions settings.
/* Since there is no return value for event subscription, error would be the only validation for now.
Returning a mock event response from open rpc and validating it against expected values from open rpc might not be of value.
This comment is applicable to all event unit tests.
*/
}
Expand Down

0 comments on commit 8741ea4

Please sign in to comment.