Skip to content

Commit

Permalink
fix: Update specs for resolutions
Browse files Browse the repository at this point in the history
  • Loading branch information
alkalinecoffee committed Aug 13, 2024
1 parent 3132236 commit 30eaac3
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
17 changes: 10 additions & 7 deletions requirements/specifications/media/media-capabilities.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,15 @@ The Firebolt `Types` module must have a `Dimensions` object of the following sch

The Firebolt `Media` module **MUST** have a `ResolutionName` enumeration:

| Class | Applicable Resolutions |
| --------- | ---------------------- |
| `sd` | `576p` and lower |
| `hd` | `720p` |
| `fhd` | `1080p` |
| `uhd` | `2160` and higher |
| `unknown` | unknown or no display |
| Class | Applicable Vertical Resolutions |
| --------- | -------------------------------- |
| `sd` | `576` |
| `hd` | `720` |
| `fhd` | `1080` |
| `4k-uhd` | `2160` |
| `8k-uhd` | `4320` |
| `other` | other or non-standard resolution |
| `unknown` | unknown resolution / no display |

### 3.4. Video Modes

Expand Down Expand Up @@ -181,6 +183,7 @@ The Firebolt `Media` module **MUST** have a `VideoMode` enumeration:
- `2160p60`
- `4320p50`
- `4320p60`
- `other`
- `unknown`

Any methods relating to the video mode (such as a device's video output mode) **MUST** return `Media.VideoMode` values.
Expand Down
2 changes: 1 addition & 1 deletion src/openrpc/display.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@
"params": [],
"result": {
"name": "Default Result",
"value": "uhd"
"value": "4k-uhd"
}
}
]
Expand Down
5 changes: 4 additions & 1 deletion src/schemas/media.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@
"sd",
"hd",
"fhd",
"uhd",
"4k-uhd",
"8k-uhd",
"other",
"unknown"
]
},
Expand Down Expand Up @@ -135,6 +137,7 @@
"2160p60",
"4320p50",
"4320p60",
"other",
"unknown"
]
}
Expand Down

0 comments on commit 30eaac3

Please sign in to comment.