fixup! chore: CI to test CPP SDK

rdkcentral · Nov 19, 2024 · 00991dd · 00991dd
1 parent 8e295c9
commit 00991dd
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/.github/workflows/cxx-build.yml b/.github/workflows/cxx-build.yml
@@ -361,22 +361,18 @@ jobs:
       - name: Install npm dependencies
         run: |
           apt update
-          apt install -y cmake
+          apt install -y cmake python3-pip python3.11-venv
+          python3 -m venv firebolt-env
+          source firebolt-env/bin/activate
+          pip install gcovr
           npm install
 
       - name: Generate core SDK source code
         run: |
           .github/workflows/utils.sh generate_cpp_core_sdk_source_code
 
       - name: Build CXX Core SDK
-        shell: bash
-        run: |
-          apt install -y python3-pip python3.11-venv
-          python3 -m venv firebolt-env
-          source firebolt-env/bin/activate
-          pip install gcovr
-
-          .github/workflows/utils.sh build_core_cpp_sdk
+        run: .github/workflows/utils.sh build_core_cpp_sdk
 
       - name: Test and Generate coverage report
         run: .github/workflows/utils.sh generate_core_sdk_coverage_report
@@ -395,8 +391,8 @@ jobs:
           thresholds: '10 20'
 
       - name: Add coverage PR comment
+        if: ${{github.event.pull_request.number}}
         uses: marocchino/sticky-pull-request-comment@v2
-        if: github.event_name == 'pull_request' || github.event_name == 'push'
         with:
           recreate: true
           path: code-coverage-results.md