Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new type ThreadId added #118

Closed
wants to merge 4 commits into from
Closed

new type ThreadId added #118

wants to merge 4 commits into from

Conversation

HaseenaSainul
Copy link
Contributor

@HaseenaSainul HaseenaSainul commented Sep 4, 2024 •
edited by sebaszm
Loading

No description provided.

sebaszm
sebaszm reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@sebaszm sebaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ::thread_id is not in Core:: ?

@HaseenaSainul
Copy link
Contributor Author

I think ::thread_id is not in Core:: ?

yes it is #118 (review) But outside namespace Core

sebaszm
sebaszm requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@sebaszm sebaszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThreadId is emitted and searched for in Core:: while it's defined in global namespace. :)

@sebaszm sebaszm self-requested a review September 10, 2024 06:54
@HaseenaSainul
Copy link
Contributor Author

There is no permission to update the branch in rdkcentral, so new PR created from fork: #130.
Hence closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebaszm sebaszm sebaszm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaseenaSainul @sebaszm