JSONRPCLink: added missing lock and locking sequence also updated to …

…avoid deadlock situations
rdkcentral · Oct 25, 2024 · c16f0c9 · c16f0c9
1 parent 5c6afdf
commit c16f0c9
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Source/websocket/JSONRPCLink.h b/Source/websocket/JSONRPCLink.h
@@ -227,16 +227,18 @@ namespace Thunder {
                 }
                 void Register(LinkType<INTERFACE>& client)
                 {
+                    _adminLock.Lock();
                     typename std::list<LinkType<INTERFACE>* >::iterator index = std::find(_observers.begin(), _observers.end(), &client);
                     ASSERT(index == _observers.end());
                     if (index == _observers.end()) {
                         _observers.push_back(&client);
                     }
+
+                    _adminLock.Unlock();
+
                     if (_channel.IsOpen() == true) {
                         client.Opened();
                     }
-
-                    _adminLock.Unlock();
                 }
                 void Unregister(LinkType<INTERFACE>& client)
                 {
@@ -246,8 +248,9 @@ namespace Thunder {
                     if (index != _observers.end()) {
                         _observers.erase(index);
                     }
-                    FactoryImpl::Instance().Revoke(&client);
                     _adminLock.Unlock();
+
+                    FactoryImpl::Instance().Revoke(&client);
                 }
                 void Submit(const Core::ProxyType<INTERFACE>& message)
                 {