Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDK-50163 Support for running Android containers #327

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jonhenderson-sky
Copy link

@jonhenderson-sky jonhenderson-sky commented May 30, 2024

  • Manage mounting android partitions
  • OCI Template modifications for Android
  • Extra settings for Android specific bind mounts and devices

It is not required to modify the base dobby.bb, but a device specific addition to the Dobby config must be made as required to support running Android on a specific device.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

- Manage mounting android partitions
- OCI Template modifications for Android
- Extra settings for Android specific bind mounts and devices
@CLAassistant
Copy link

CLAassistant commented May 30, 2024

CLA assistant check
All committers have signed the CLA.

@jonhenderson-sky jonhenderson-sky changed the title RDK-50163Support for running Android containers RDK-50163 Support for running Android containers May 30, 2024
Signed-off-by: Jon Henderson <[email protected]>
Provide the ability to use an alternate AppArmor profile when running
android containers, i.e.

{
    "android": {
        "appArmorProfile": "aosp_default"
    }
}

If no setting is provided, the normal Dobby profile will be used.
@@ -373,6 +374,10 @@ if(PLUGIN_GAMEPAD)
add_subdirectory(rdkPlugins/Gamepad)
endif()

if(PLUGIN_ANDROIDRUNTIME)
add_subdirectory(rdkPlugins/AndroidRuntime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the rdkPlugins/AndroidRuntime directory in this PR

@goruklu
Copy link
Contributor

goruklu commented Jun 13, 2024

@jonhenderson-sky The unit tests and builds are failing, can you please correct those ?
Also, It would be great if you can add some unit tests for the Android container use case

@goruklu goruklu linked an issue Sep 11, 2024 that may be closed by this pull request
Support single compressed system.img (sqfs or erofs)
Remove special kernel commandline handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Android containers
3 participants