-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDK-50163 Support for running Android containers #327
Open
jonhenderson-sky
wants to merge
5
commits into
rdkcentral:master
Choose a base branch
from
jonhenderson-sky:android_runtime_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RDK-50163 Support for running Android containers #327
jonhenderson-sky
wants to merge
5
commits into
rdkcentral:master
from
jonhenderson-sky:android_runtime_support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Manage mounting android partitions - OCI Template modifications for Android - Extra settings for Android specific bind mounts and devices
jonhenderson-sky
changed the title
RDK-50163Support for running Android containers
RDK-50163 Support for running Android containers
May 30, 2024
Signed-off-by: Jon Henderson <[email protected]>
Provide the ability to use an alternate AppArmor profile when running android containers, i.e. { "android": { "appArmorProfile": "aosp_default" } } If no setting is provided, the normal Dobby profile will be used.
goruklu
requested changes
Jun 13, 2024
@@ -373,6 +374,10 @@ if(PLUGIN_GAMEPAD) | |||
add_subdirectory(rdkPlugins/Gamepad) | |||
endif() | |||
|
|||
if(PLUGIN_ANDROIDRUNTIME) | |||
add_subdirectory(rdkPlugins/AndroidRuntime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the rdkPlugins/AndroidRuntime directory in this PR
@jonhenderson-sky The unit tests and builds are failing, can you please correct those ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not required to modify the base dobby.bb, but a device specific addition to the Dobby config must be made as required to support running Android on a specific device.
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb
) must be modified to support the changes in this PR (beyond updatingSRC_REV
)