Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve latest version error message #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JackBurdick
Copy link

No worries if you don't want to include. Please double-check on your end.

This was my first time using a release and this error message could have saved me a bit of time.

NOTE: I was surprised to find that if I used latest_release.json()['tag_name'] twice in the same block I received an error (which is why gh_json = latest_release.json() exists). I then changed file_list_json = file_list.json() in _download_all_files to match -- but will take out if desired.

I (my fixer) also removed a couple extra spaces at the end of lines and I decided to include

and a couple extra spaces removed
@rdehuyss
Copy link
Owner

rdehuyss commented May 6, 2021

Thx for this! I will soon have a look, test it and merge it then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants