Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

issue detail links in Budget/Rewards app not working #610

Closed
dckc opened this issue Apr 20, 2018 · 3 comments
Closed

issue detail links in Budget/Rewards app not working #610

dckc opened this issue Apr 20, 2018 · 3 comments
Assignees
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13

Comments

@dckc
Copy link
Contributor

dckc commented Apr 20, 2018

@kitblake writes in #491:

In the Budget/Rewards app I'm getting no visible reaction when trying to access issue details ...

I noticed that too; I think it's more than a usability paper-cut.

In Chrome developer tools, I see:

Refused to display 'https://rewards.rchain.coop/index.php?-table=issue&-action=browse&-cursor=0&-skip=0&-limit=30&-mode=list&-recordid=issue%3Fnum%3D1&-ui-root=main-content' in a frame because it set 'X-Frame-Options' to 'deny'.

I don't know what changed w.r.t. X-Frame-Options. I'm looking into it.

Benefit to RChain Membership

Makes the bounty rewards app usable.

Estimated Budget of Task: $200 to $400
Estimated Timeline Required to Complete the Task: 2 to 4 hrs
Measure of Completion: links work again

@dckc dckc added Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13 labels Apr 20, 2018
@dckc dckc self-assigned this Apr 20, 2018
@kitblake kitblake self-assigned this Apr 20, 2018
@dckc
Copy link
Contributor Author

dckc commented Apr 20, 2018

fixed:

  • restore details links: disable G2 8823b21c0d5b

@dckc dckc closed this as completed Apr 20, 2018
@dckc
Copy link
Contributor Author

dckc commented Apr 20, 2018

ugh... now I can't find any "add" links.

@dckc dckc reopened this Apr 20, 2018
@dckc
Copy link
Contributor Author

dckc commented Apr 20, 2018

@jeremybusk wrote:

I did add DENY to global when I was adding in a bunch of other features. ... It should work now...
add_header X-Frame-Options SAMEORIGIN;

@dckc dckc closed this as completed Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13
Projects
None yet
Development

No branches or pull requests

2 participants