Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

bounty voting app usability paper-cuts #491

Closed
3 tasks
dckc opened this issue Mar 14, 2018 · 49 comments
Closed
3 tasks

bounty voting app usability paper-cuts #491

dckc opened this issue Mar 14, 2018 · 49 comments
Assignees
@David405
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...)

Comments

@dckc
Copy link
Contributor

dckc commented Mar 14, 2018 •
edited
Loading

The bounty web app pretty much works, but there are various usability "paper cuts"

  • anywhere you see an issue or a user (e.g. on a budget vote or a reward vote) it should be a link to the issue or user page
  • search for issue by number doesn't work
  • filtering got messed up by the dashboard

grr... adding new votes triggers an error:

ParseError: syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in /var/www/html/xataface-2.1.3/Dataface/LanguageTool.php(223) : eval()'d code:2

It's somewhat harmless: the vote gets counted. But it's a pain.

I'm not the first to report these symptoms with xataface: PHP errors when adding relationship from existing data.

Looks like there's a Sep 16, 2016 fix but no release has been cut since then. :-/

In fact there have been 103 commits since Xataface v2.1.3 released Aug 31, 2016. I made a request for a release.

Diagnosing this probably involves setting up a test instance of the app and exploring either PHP versions or, more likely, unreleased versions of xataface.

originally reported March 13

cc @hyperevo @petereitz
@dckc dckc added the Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) label Mar 14, 2018
@David405
Copy link

Are you certain this error is caused by version conflicts? I think perhaps something was omitted in the code, maybe debugging could solve the problem( my suggestion though), can you share a link to file where this is occurring?

@David405
Copy link

The app refuses to run on my local server, I can't seem to trace the problem, it throws a 500 internal server error but a clone of the xataface repo runs fine.

@David405
Copy link

David405 commented Mar 15, 2018 •
edited
Loading

One last thing, when logging into rewards.rchain.coop, the authorize button in the github oauth page didn't work in mobile, it only works when logging in from a computer, is this intentional or a bug?

@dckc
Copy link
Contributor Author

dckc commented Mar 15, 2018

"doesn't work" is not helpful.

@Valentine-Mario
Copy link

I tried to log in to the Web app @http://rewards.rchain.coop but I couldn't. How do I resolve this?

@dckc
Copy link
Contributor Author

dckc commented Mar 17, 2018

If you want help, @Valentine-Mario, you should be precise and informative about your problem.

Did you get an error including "unexpected T_ENCAPSED_AND_WHITESPACE"? If not, perhaps your problem is not relevant to this issue.

@dckc dckc changed the title bounty voting app: unexpected T_ENCAPSED_AND_WHITESPACE due to PHP vs. xataface versions bounty voting app usability paper-cuts Mar 20, 2018
@dckc
Copy link
Contributor Author

dckc commented Mar 20, 2018

I suppose I'll widen the scope of this to include other usability issues.

@dckc dckc added the zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13 label Mar 21, 2018
@dckc dckc mentioned this issue Mar 21, 2018
Closed
7 tasks
@TrenchFloat
Copy link
Contributor

Under the "budget" tab and "reward" tab, I couldn't find any issues that were closed in GitHub. The one I was looking for, #467, was both opened and closed in March, but should we also consider budget carry-over on closed issues before we omit them from the list?

Anyway, I found it under the "Issues" tab and voted on it from there.

@dckc
Copy link
Contributor Author

dckc commented Mar 21, 2018

In the "budget" tab and "reward" tab, you should only expect to find issues where somebody has voted. The "Issues" tab is usually the place to start.

@dckc
Copy link
Contributor Author

dckc commented Mar 23, 2018

woot!

With help from @petereitz, I upgraded xataface, and now rather than "technical difficulties" we get:

Record successfully added to "BudgetVotes" relationship.

dckc/rchain-dbr@a1791e5

@dckc
Copy link
Contributor Author

dckc commented Mar 23, 2018

With @petereitz , I fixed a couple missing-link papercuts.

dckc/rchain-dbr@74d8c8a

@dckc
Copy link
Contributor Author

dckc commented Mar 23, 2018

Oops! The Xataface upgrade broke login. I know why... Need to put the custom login module in place

@dckc
Copy link
Contributor Author

dckc commented Mar 23, 2018

Login restored.

@petereitz , we forgot about this part:

    - name: install XDB module
      synchronize:
        src: "{{ install_dir }}/xataface_template/modules/"
        dest: "{{ xf_dir }}/modules/"

-- https://github.com/dckc/rchain-dbr/blob/master/playbook.yml#L18-L21

@lapin7
Copy link
Contributor

lapin7 commented Mar 24, 2018 •
edited
Loading

Anyone:
Please enter one more reward-vote for #529 @lapin7
Then I can try out the invoice part of the bounty-system

@burn1ngchr0me
Copy link

burn1ngchr0me commented Mar 24, 2018 via email

@dckc
Copy link
Contributor Author

dckc commented Mar 24, 2018

The invoice info tab already has 7 entries, @lapin7 .

@lapin7
Copy link
Contributor

lapin7 commented Mar 25, 2018

@pythonical and @peetklasen only "verified members" are allowed to enter votes for budget and reward. I don't know how this status can be changed in the bounty-system.

@dckc I would like to export to csv the invoice rows per member. Let me write down some specs for invoice creation.

Description of Issue   USD

@dckc
Copy link
Contributor Author

dckc commented Mar 25, 2018

The Verify Coop Membership link is in the upper right menu under your login (after you log in).

A detail: un-verified users are allowed to enter votes; they just get ignored in the budget/reward calculations until the user is verified.

@Tonyprisca13
Copy link

I am a verified coop why cant i vote or budget?

@dckc dckc mentioned this issue Mar 25, 2018
Closed
@dckc
Copy link
Contributor Author

dckc commented Mar 25, 2018

Are you sure you cannot? What happens when you try?

@kitblake
Copy link
Contributor

Fwiw, I just verified and I think it worked. Then I did it again.

But I'm not sure it has any effect. I was trying to add a budget for "RChain Coop Membership Benefit #520" but the issue is not showing up in the listing:
Budget tab > Click "Issue Num" heading > Click reverse order triangle > See issues in reverse order

@dckc
Copy link
Contributor Author

dckc commented Mar 25, 2018 via email

@burn1ngchr0me
Copy link

burn1ngchr0me commented Mar 25, 2018 via email

@dckc
Copy link
Contributor Author

dckc commented Mar 25, 2018

It worked. Look at the "Verified coop" field in your user record. Also note that your votes are getting counted, for example in the rewards for lapin7 on issue 529.

@dckc
Copy link
Contributor Author

dckc commented Mar 25, 2018

@kitblake I don't see any budget votes from you on #520. Describe the exact steps you took to vote?

Everybody, for 4th time: take care with your problem reports. "It doesn't work" is no help in diagnosing problems. It's important to to say

  1. exactly what you did
  2. exactly what you expected, and
  3. exactly what you experienced instead.

@lapin7
Copy link
Contributor

lapin7 commented Mar 26, 2018

@kitblake since you managed to become a "verified member" please add a budget vote to #529

@kmoskowitz
Copy link

I am trying to vote for rewards on issue #471 I already made budget vote, but when i pull up the window for rewards vote, no button shows up to allow me to vote. Not sure how to proceed.

@dckc
Copy link
Contributor Author

dckc commented Mar 28, 2018

I can't reproduce the problem, @kmoskowitz; when I start at the Issue tab, bring up 471, and follow the link to RewardVotes on 471, I see a New RewardVote button. I made an annotated screenshot.

@kmoskowitz
Copy link

kmoskowitz commented Mar 28, 2018 via email

@lapin7 lapin7 mentioned this issue Mar 28, 2018
Closed
24 tasks
@lapin7
Copy link
Contributor

lapin7 commented Mar 30, 2018 •
edited
Loading

Thanks to @dckc 's ImportHTML we have a data connection between Gsheet and the Bounty App.

I'm now busy with a spreadsheet that can create your personal invoices. It has all the personal data and it's usable starting from March onwards. You just have to create an "invoice overview" in the bounty app and fill out the period in the spreadsheet and your github name.

Tomorrow I will copy this template to your personal invoices spreadsheet.

You can have a look at it in InvoiceTemplate

@dckc
Copy link
Contributor Author

dckc commented Mar 30, 2018

You just have to create an "invoice overview" in the bounty app

I don't think so. As I noted in #548, the InvoiceInfo tab is gone from rewards.rchain.coop. The IMPORTHTML in the invoice spreadsheet template just uses the Rewards tab and filters on worker and pay period.

@kmoskowitz
Copy link

I voted placed my rewards vote on issue #471, but when I check rewards vote is not showing up.

@kitblake
Copy link
Contributor

kitblake commented Apr 1, 2018

@kmoskowitz First make sure you're logged in, then click the disclosure triangle next to your name and choose "Verify Co-op Membership". You should be redirected to Discord and see a "Verify" overlay. Click "Authorize" and you'll be returned to the BudgetRewards app. Now you should be able to vote.

@kmoskowitz
Copy link

Hmmm... I thought my Co-op membership was already verified. I don't see the disclosure triangle. To be clear, I was able to vote, and it shows that I voted under the RewardsVote tab. When I click on the Rewards tab to the left, and look under Voters, my name does not show up. Issue #471

@kitblake
Copy link
Contributor

kitblake commented Apr 2, 2018

@kmoskowitz I see what you see, namely votes that are listed in the RewardVotes tab are missing in the Rewards tab.
Escalating to @dckc..

@dckc
Copy link
Contributor Author

dckc commented Apr 2, 2018

The kmoskowitz user record has no "Verified coop" field. So while you can cast votes, they won't be counted yet.

Verifying coop membership in this context means connecting your github and discord profiles. See the Verify your Coop Membership section of How To Use the Budget Rewards Web App.

@kmoskowitz
Copy link

kmoskowitz commented Apr 3, 2018 via email

@dckc
Copy link
Contributor Author

dckc commented Apr 3, 2018

Your user record shows your discord member profile has been verified. Your votes count now.

@dckc
Copy link
Contributor Author

dckc commented Apr 7, 2018

  • ca19b85 dbr_triggers: only current vote changes allowed

I only put database constraints (triggers) in place. Ideally the constraints would be clear in the web app too, but for now, you'll just get an error if you try to make an edit outside the current pay period.

@kitblake
Copy link
Contributor

kitblake commented Apr 19, 2018 •
edited by dckc
Loading

In the Budget/Rewards app I'm getting no visible reaction when trying to access issue details (which normally appear in the lower frame after locating an issue). Steps:

  1. Search for an issue by number.
  2. Click on the found issue link. There is a request but nothing happens on the page. The lower frame remains empty.

The workaround is to copy the link, then paste & go in the location bar. Then the details load and budgets/rewards can be edited.
(So @dckc and/or @TrenchFloat should relax and enjoy the Dev conf.)

p.s. escalated to #610 -- @dckc

@kitblake kitblake mentioned this issue Apr 20, 2018
Closed
4 tasks
@kitblake
Copy link
Contributor

kitblake commented Apr 20, 2018 •
edited
Loading

Btw, I miss the Status page with the handy links, such as:
My budget votes: https://rewards.rchain.coop/index.php?-action=related_records_list&-relationship=BudgetVotes&-table=github_users&login=%3Dkitblake
My reward votes: https://rewards.rchain.coop/index.php?-action=related_records_list&-relationship=RewardVotes&-table=github_users&login=%3Dkitblake
And: What did I do? https://rewards.rchain.coop/aux/user?login=kitblake

These links could go in the sidebar too, plenty of room.

@dckc dckc mentioned this issue Apr 20, 2018
Closed
@kitblake
Copy link
Contributor

Hey, nice latent filter: 'Showing matches for query Search: "2018-04-01"'

@dckc dckc mentioned this issue Apr 30, 2018
Closed
@allancto allancto mentioned this issue May 9, 2018
Closed
@kitblake
Copy link
Contributor

I'm getting a traceback when updating issues from Github:
pymysql.err.InternalError: (1366, "Incorrect string value: '\xE2\x80\x8A - ...' for column 'title' at row 607")

@dckc
Copy link
Contributor Author

dckc commented May 17, 2018

long overdue: link from an issue page in the web app to the github issue:

  • 5bb48e5c6a14 papercuts: link to issue

I fixed the Incorrect string value bug in 3efc87c, too, @kitblake .

@TrenchFloat TrenchFloat removed the zz-Operations NEEDS SPONSOR guides: @TrenchFloat, @jimscarver @Tonyprisca13 label Jun 8, 2018
@kitblake
Copy link
Contributor

kitblake commented Jun 9, 2018 •
edited
Loading

Can we increase the session length on the rewards server? I think it's default 20 minutes, and people at the end of the month are often busy for an hour or two.
@jimscarver

@dckc
Copy link
Contributor Author

dckc commented Jun 9, 2018 via email

@David405 David405 self-assigned this Aug 8, 2018
@dckc
Copy link
Contributor Author

dckc commented Sep 6, 2018

Thanks to @David405 and @jimscarver for helping me make time to fix a couple:

  • ea8e069 2018-08-09 paper cut: display exception message
  • 7eaeb06 2018-08-09 make link_markup available to issue.php

I have no particular plans to work on this further. I'm closing this until something specific comes up.

@dckc dckc closed this as completed Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@David405 David405

Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dckc @kitblake @lapin7 @burn1ngchr0me @TrenchFloat @David405 @Valentine-Mario @Tonyprisca13 @kmoskowitz