Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substantial refactor #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ghoneycutt
Copy link

Lots of style fixes to pass puppet-lint and created parameterized
classes which allow for data to specified with Hiera in Puppetv3.

Lots of style fixes to pass puppet-lint and created parameterized
classes which allow for data to specified with Hiera in Puppetv3.
@razorsedge
Copy link
Owner

@ghoneycutt : You may want to rebase onto the develop branch. I am about to release a version 3.0.0.

@naevtamarkus
Copy link

+1 to this one!!

@anders-larsson
Copy link
Contributor

Would love to have the functionality of configuration the network module using hiera which this pull request includes. Would it be possible to push this pull request further @razorsedge and @ghoneycutt? Otherwise should a separate pull request be created with this functionality?

@ghoneycutt
Copy link
Author

@anders-larsson you have this compatibility :)

Your Puppetfile should have my repo and this branch

@anders-larsson
Copy link
Contributor

True enough :)

Would be nice to use the upstream version though since it has received a lot of new features and are actively developed. Just thought it would be nice if hiera support could be merged into the upstream module. More features for everyone. Thank you for responding.

@razorsedge razorsedge mentioned this pull request Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants