-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new api for masked contact number in phone number module [ATLAS-197] #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4b328b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
Bundle Size Report
|
🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
---|
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
📈 | cjs/index.js |
138.9 |
146.13 |
|
5.21 |
📈 | esm/index.min.js |
51.45 |
52.74 |
|
2.51 |
📈 | umd/index.js |
158.85 |
166.67 |
|
4.92 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RgnDunes
changed the title
feat: add new api for masked contact number in phone number module
feat: add new api for masked contact number in phone number module [ATLAS-197]
May 8, 2024
This comment has been minimized.
This comment has been minimized.
tarun-khanna
reviewed
May 8, 2024
packages/i18nify-js/src/modules/phoneNumber/getMaskedPhoneNumber.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/i18nify-js/src/modules/phoneNumber/__tests__/getMaskedPhoneNumber.test.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/__tests__/getMaskedPhoneNumber.test.ts
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/__tests__/getMaskedPhoneNumber.test.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/__tests__/getMaskedPhoneNumber.test.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/getMaskedPhoneNumber.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/getMaskedPhoneNumber.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/getMaskedPhoneNumber.ts
Outdated
Show resolved
Hide resolved
packages/i18nify-js/src/modules/phoneNumber/getMaskedPhoneNumber.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results0 files 0 suites 0s ⏱️ Results for commit 84ef659. |
packages/i18nify-js/src/modules/phoneNumber/__tests__/getMaskedPhoneNumber.test.ts
Show resolved
Hide resolved
tarun-khanna
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module adds a new API that returns us a masked contact number as shown below:
Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)