Mod/library card textarea #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 116fc98): https://dmkit-e7e99--pr41-mod-librarycardtexta-rpolk2fn.web.app (expires Mon, 25 Mar 2024 08:33:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 310a7f1d940a0f8f9346804f5fc60f8ba2a4f18d |
rayzhou-bit
requested changes
Mar 3, 2024
| className="library-card-textarea" | ||
| isSelected={isSelected} | ||
| lib={true} | ||
| className={`library-card-textarea ${isSelected ? "selected" : ""}`} |
There was a problem hiding this comment.
Could you pull out the code from ContentTextarea into LibraryCard? (And delete ContentTextarea).
rayzhou-bit
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes provide a better functionality to the libraryCard textarea text. This replaces my complicated js truncation with CSS using -webkit-line-clamp. These changes may not be great in all browsers.
The previous truncation only allowed a working visual of one line followed by ellipsis