Skip to content

Commit

Permalink
Fix non-visible line number on light-colored backgrounds
Browse files Browse the repository at this point in the history
Explicitly setting the color to white was a mistake, as it would make it
invisible on light-colored backgrounds. Instead, we only make the text
bold. This has the same visual effect on dark backgrounds, but also
works for light backgrounds as well.

Change-Id: If4c927e5e91b4017b29db1cc492740cbd9497d30
Reviewed-on: http://gerrit.causes.com/45798
Tested-by: jenkins <[email protected]>
Reviewed-by: Shane da Silva <[email protected]>
  • Loading branch information
sds committed Jan 17, 2015
1 parent 7c28701 commit 9df12f7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# HAML-Lint Changelog

## master (unreleased)

* Fix non-visible line number on light-colored terminal backgrounds

## 0.11.0

* Fix `SpaceInsideHashAttributes` not reporting lints for implicit div tags
Expand Down
2 changes: 1 addition & 1 deletion lib/haml_lint/logger.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def log(output, newline = true)
# @param args [Array<String>]
# @return [nil]
def bold(*args)
color('1;37', *args)
color('1', *args)
end

# Print the specified output in a color indicative of error.
Expand Down

0 comments on commit 9df12f7

Please sign in to comment.