This repository has been archived by the owner on Nov 15, 2024. It is now read-only.
Use idempotent ATA creation to avoid tx race conditions #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raydium-sdk code is prone to race conditions for cases when an ATA is checked for existence, then a
createAssociatedTokenAccountInstructionis added to the tx.If two swaps detect the ATA missing and add the ATA creation instruction, only the first will succeed, while the second will fail with
InvalidOwner.Example:
This PR replaces
createAssociatedTokenAccountInstructionwithcreateAssociatedTokenAccountIdempotentInstruction, which does not fail even if the ATA already exists.