fix: set default language for new profiles to any

* this only applies to products which do have languages in profiles
raydak-labs · Nov 20, 2024 · ffd6faa · ffd6faa
1 parent b9ad772
commit ffd6faa
Show file tree

Hide file tree

Showing 5 changed files with 95 additions and 12 deletions.
diff --git a/src/clients/radarr-client.ts b/src/clients/radarr-client.ts
@@ -1,11 +1,18 @@
 import { KyHttpClient } from "../__generated__/ky-client";
 import { Api } from "../__generated__/radarr/Api";
-import { CustomFormatResource, QualityDefinitionResource, QualityProfileResource } from "../__generated__/radarr/data-contracts";
+import {
+  CustomFormatResource,
+  LanguageResource,
+  QualityDefinitionResource,
+  QualityProfileResource,
+} from "../__generated__/radarr/data-contracts";
 import { logger } from "../logger";
+import { cloneWithJSON } from "../util";
 import { IArrClient, validateClientParams } from "./unified-client";
 
-export class RadarrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource> {
+export class RadarrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource, LanguageResource> {
   private api!: Api<unknown>;
+  private languageMap: Map<string, LanguageResource> = new Map();
 
   constructor(baseUrl: string, apiKey: string) {
     this.initialize(baseUrl, apiKey);
@@ -24,13 +31,18 @@ export class RadarrClient implements IArrClient<QualityProfileResource, QualityD
     this.api = new Api(httpClient);
   }
 
+  async getLanguages() {
+    return this.api.v3LanguageList();
+  }
+
   // Quality Management
   getQualityDefinitions() {
     return this.api.v3QualitydefinitionList();
   }
 
   async updateQualityDefinitions(definitions: QualityDefinitionResource[]) {
     await this.api.v3QualitydefinitionUpdateUpdate(definitions);
+    this.api.v3LanguageList();
     return this.getQualityDefinitions();
   }
 
@@ -39,10 +51,19 @@ export class RadarrClient implements IArrClient<QualityProfileResource, QualityD
     return this.api.v3QualityprofileList();
   }
 
-  createQualityProfile(profile: QualityProfileResource): Promise<QualityProfileResource> {
-    if (profile.language) {
+  async createQualityProfile(profile: QualityProfileResource): Promise<QualityProfileResource> {
+    const cloned = cloneWithJSON(profile);
+
+    if (this.languageMap.size <= 0) {
+      const languages = await this.getLanguages();
+      this.languageMap = new Map(languages.map((i) => [i.name!, i]));
     }
-    return this.api.v3QualityprofileCreate(profile);
+
+    if (profile.language == null) {
+      cloned.language = this.languageMap.get("Any");
+    }
+
+    return this.api.v3QualityprofileCreate(cloned);
   }
 
   updateQualityProfile(id: string, profile: QualityProfileResource): Promise<QualityProfileResource> {

diff --git a/src/clients/readarr-client.ts b/src/clients/readarr-client.ts
@@ -2,14 +2,17 @@ import { KyHttpClient } from "../__generated__/ky-client";
 import { Api } from "../__generated__/readarr/Api";
 import {
   CustomFormatResource,
+  LanguageResource,
   MetadataProfileResource,
   QualityDefinitionResource,
   QualityProfileResource,
 } from "../__generated__/readarr/data-contracts";
 import { logger } from "../logger";
 import { IArrClient, validateClientParams } from "./unified-client";
 
-export class ReadarrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource> {
+export class ReadarrClient
+  implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource, LanguageResource>
+{
   private api!: Api<unknown>;
 
   constructor(baseUrl: string, apiKey: string) {
@@ -29,6 +32,10 @@ export class ReadarrClient implements IArrClient<QualityProfileResource, Quality
     this.api = new Api(httpClient);
   }
 
+  async getLanguages() {
+    return this.api.v1LanguageList();
+  }
+
   // Quality Management
   getQualityDefinitions() {
     return this.api.v1QualitydefinitionList();

diff --git a/src/clients/sonarr-client.ts b/src/clients/sonarr-client.ts
@@ -1,6 +1,11 @@
 import { KyHttpClient } from "../__generated__/ky-client";
 import { Api } from "../__generated__/sonarr/Api";
-import { CustomFormatResource, QualityDefinitionResource, QualityProfileResource } from "../__generated__/sonarr/data-contracts";
+import {
+  CustomFormatResource,
+  LanguageResource,
+  QualityDefinitionResource,
+  QualityProfileResource,
+} from "../__generated__/sonarr/data-contracts";
 import { logger } from "../logger";
 import { IArrClient, validateClientParams } from "./unified-client";
 
@@ -10,7 +15,7 @@ export type SonarrQualityProfileResource = {
   // Add other common properties that all quality profiles share
 };
 
-export class SonarrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource> {
+export class SonarrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource, LanguageResource> {
   private api!: Api<unknown>;
 
   constructor(baseUrl: string, apiKey: string) {
@@ -30,6 +35,10 @@ export class SonarrClient implements IArrClient<QualityProfileResource, QualityD
     this.api = new Api(httpClient);
   }
 
+  async getLanguages() {
+    return this.api.v3LanguageList();
+  }
+
   // Quality Management
   getQualityDefinitions() {
     return this.api.v3QualitydefinitionList();

diff --git a/src/clients/unified-client.ts b/src/clients/unified-client.ts
@@ -84,10 +84,17 @@ export type ArrClientQualityProfile = {
   // Add other common properties that all quality profiles share
 };
 
+export type ArrClientLanguageResource = {
+  id?: number;
+  name?: string | null;
+  nameLower?: string | null;
+};
+
 export interface IArrClient<
   QP extends ArrClientQualityProfile = MergedQualityProfileResource,
   QD extends ArrClientQualityDefinition = MergedQualityDefinitionResource,
   CF extends ArrClientCustomFormat = MergedCustomFormatResource,
+  L extends ArrClientLanguageResource = ArrClientLanguageResource,
 > {
   // Quality Management
   getQualityDefinitions(): Promise<QD[]>;
@@ -104,6 +111,8 @@ export interface IArrClient<
   updateCustomFormat(id: string, format: CF): Promise<CF>;
   deleteCustomFormat(id: string): Promise<void>;
 
+  getLanguages(): Promise<L[]>;
+
   // System/Health Check
   getSystemStatus(): Promise<any>;
   testConnection(): Promise<boolean>;
@@ -138,6 +147,10 @@ export class UnifiedClient implements IArrClient {
     return this.api as T;
   }
 
+  async getLanguages() {
+    return this.api.getLanguages();
+  }
+
   async getQualityDefinitions() {
     return await this.api.getQualityDefinitions();
   }

diff --git a/src/clients/whisparr-client.ts b/src/clients/whisparr-client.ts
@@ -1,11 +1,29 @@
 import { KyHttpClient } from "../__generated__/ky-client";
 import { Api } from "../__generated__/whisparr/Api";
-import { CustomFormatResource, QualityDefinitionResource, QualityProfileResource } from "../__generated__/whisparr/data-contracts";
+import {
+  CustomFormatResource,
+  LanguageResource,
+  QualityDefinitionResource,
+  QualityProfileResource,
+} from "../__generated__/whisparr/data-contracts";
 import { logger } from "../logger";
+import { cloneWithJSON } from "../util";
 import { IArrClient, validateClientParams } from "./unified-client";
 
-export class WhisparrClient implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource> {
+/**
+ * Overwrite wrong types for now
+ */
+declare module "../__generated__/whisparr/data-contracts" {
+  export interface QualityProfileResource {
+    language?: Language;
+  }
+}
+
+export class WhisparrClient
+  implements IArrClient<QualityProfileResource, QualityDefinitionResource, CustomFormatResource, LanguageResource>
+{
   private api!: Api<unknown>;
+  private languageMap: Map<string, LanguageResource> = new Map();
 
   constructor(baseUrl: string, apiKey: string) {
     this.initialize(baseUrl, apiKey);
@@ -24,6 +42,10 @@ export class WhisparrClient implements IArrClient<QualityProfileResource, Qualit
     this.api = new Api(httpClient);
   }
 
+  async getLanguages() {
+    return this.api.v3LanguageList();
+  }
+
   // Quality Management
   getQualityDefinitions() {
     return this.api.v3QualitydefinitionList();
@@ -39,8 +61,19 @@ export class WhisparrClient implements IArrClient<QualityProfileResource, Qualit
     return this.api.v3QualityprofileList();
   }
 
-  createQualityProfile(profile: QualityProfileResource) {
-    return this.api.v3QualityprofileCreate(profile);
+  async createQualityProfile(profile: QualityProfileResource): Promise<QualityProfileResource> {
+    const cloned = cloneWithJSON(profile);
+
+    if (this.languageMap.size <= 0) {
+      const languages = await this.getLanguages();
+      this.languageMap = new Map(languages.map((i) => [i.name!, i]));
+    }
+
+    if (profile.language == null) {
+      cloned.language = this.languageMap.get("Any");
+    }
+
+    return this.api.v3QualityprofileCreate(cloned);
   }
 
   updateQualityProfile(id: string, profile: QualityProfileResource) {