Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] update XGBoost model format to UBJ #41442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Nov 28, 2023

Why are these changes needed?

Update checkpoint format to UBJ, which is the recommended format now according dmlc/xgboost#7547

Note: This is technically backward incompatible, in the sense that a checkpoint that was saved in the previous json format would not be able to be loaded in this new format.

Related issue number

Closes #41374

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this backwards compatible for a release on the loading side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving XGBoost model with json extension
2 participants