Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of path params using generic request #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yehya
Copy link

@yehya yehya commented Feb 13, 2019

This will allow providing a URL with params provided for a path like '/ex/:id/name' using the generic request method rather than using .put .get etc...

In this way the request can be done as follows:

const id = "123";
client.request<'/ex/:id/name', 'GET'>({ url: '/ex/${id}/name'}); // this rather than
client.get<'/ex/:id/name'>('/ex/${id}/name', {...}); // this

Being forced to use .get .post and others to allow for path params is more work than necessary.

@yehya
Copy link
Author

yehya commented Mar 25, 2019

Any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant