Infinity fixes #12
Closed
Infinity fixes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@infusion I was just wondering if you have had a chance to look at any of these commits? The library could do with better tests for infinite behaviours and I would be up for having a go at writing some but would like to know if you were happy with the changes before I put time into writing tests. |
|
Ping @infusion |
|
Closing in light of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more commits to improve support for infinite values. Some commits are bugfixes, others are more subjective - feel free to reject the div commit but that's my take on it.
Do you want to expose
Complex.ComplexInfinityto users? I changed the property name to reflect the fact that is isn't Infinity but is ComplexInfinity but am wondering if this needs to be a public property at all.