Clean up deprecated arguments #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 23, 2024 18:44
|
Thank you for the changes! I'm gonna review this soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #380 +/- ##
=====================================
Coverage ? 88.68%
=====================================
Files ? 33
Lines ? 716
Branches ? 0
=====================================
Hits ? 635
Misses ? 60
Partials ? 21 ☔ View full report in Codecov by Sentry. |
|
Closing the PR for the sake of cleanup. Feel free to use the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #300.
There is a bit of uncertainty. I'm not sure if I understood your intention with deprecating the sitemap flag - my guess is, that the functionality is intended be removed.
If that interpretation is correct, I will add some refactoring to the PR, to make sure the now-unnecessary sitemap related remnants are cleaned up.