#44 Fixed scrolling and added width option

raulfraile · Oct 14, 2013 · 7bfe11c · 7bfe11c
1 parent bff11db
commit 7bfe11c
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/src/Ladybug/Renderer/AbstractRenderer.php b/src/Ladybug/Renderer/AbstractRenderer.php
@@ -23,13 +23,17 @@ abstract class AbstractRenderer implements RendererInterface
     /** @var \Ladybug\Theme\ThemeResolver $themeResolver */
     protected $themeResolver;
 
+    /** @var array $options */
+    protected $options;
+
     /**
      * Constructor
      * @param \Ladybug\Theme\ThemeResolver $themeResolver
      */
-    public function __construct(ThemeResolver $themeResolver)
+    public function __construct(ThemeResolver $themeResolver, $options = array())
     {
         $this->themeResolver = $themeResolver;
+        $this->options = $options;
     }
 
     /**

diff --git a/src/Ladybug/Renderer/HtmlRenderer.php b/src/Ladybug/Renderer/HtmlRenderer.php
@@ -31,6 +31,8 @@ public function render(array $nodes, array $extraData = array())
     {
         $this->loadTemplatingEngine();
 
+        $extraData = array_merge($extraData, array('options' => $this->options));
+
         return $this->templatingEngine->render('layout.html.twig', array_merge(array(
             'nodes' => $nodes,
             'css' => $this->getCssContents(),

diff --git a/src/Ladybug/Resources/container/container.xml b/src/Ladybug/Resources/container/container.xml
@@ -19,6 +19,11 @@
         <parameter key="object_max_nesting_level">3</parameter>
         <parameter key="expanded">false</parameter>
         <parameter key="silenced">false</parameter>
+
+        <parameter key="renderer.html" type="collection">
+            <parameter key="width">500px</parameter>
+        </parameter>
+
     </parameters>
 
     <services>

diff --git a/src/Ladybug/Resources/container/renderers.xml b/src/Ladybug/Resources/container/renderers.xml
@@ -8,6 +8,7 @@
 
         <service id="render_html" class="Ladybug\Renderer\HtmlRenderer">
             <argument type="service" id="theme_resolver" />
+            <argument>%renderer.html%</argument>
             <tag name="ladybug.renderer" />
         </service>
 

diff --git a/src/Ladybug/Theme/Base/View/Html/iframe.html.twig b/src/Ladybug/Theme/Base/View/Html/iframe.html.twig
@@ -1,4 +1,4 @@
-<iframe id="ladybug_iframe_{{ id }}" frameborder="0" width="500" height="100" style="margin: 5px;overflow:hidden"></iframe>
+<iframe id="ladybug_iframe_{{ id }}" frameborder="0" width="{{ options.width }}" height="100" style="margin: 5px;overflow:hidden" scrolling="no"></iframe>
 <input type="hidden" id="ladybug_theme_{{ id }}" value="{{ theme }}" />
 <script>
     function resizeIframe{{ id }}(height, width) {