Fitter interface #226
Merged
Fitter interface #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a nice idea, I will review soon. |
tannerbk
reviewed
Jan 20, 2025
| * | ||
| * @param id PMT ID. | ||
| */ | ||
| unsigned int GetNhits(Int_t id) { |
There was a problem hiding this comment.
This is confusingly named. "Nhits" refers to the number of PMT hits in an event, not the number of "hits" on a PMT. This could be more aptly named "GetNPEs".
Additionally, you could add a method for nhits that returns the length of the appropriate hit PMT list.
There was a problem hiding this comment.
Both implemented -- the old GetNHits is now called GetNPEs. There's now a new GetNHits method.
JamesJieranShen
force-pushed
the
fitter-interface
branch
from
036b472 to
ebc4905
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new class --
FitterInputHandler, which returns charge and timing information of the event to fitters. This removes the need for fitters to deal with multiple types of PMT information, from DigitPMT/PMT/Waveformanalyzers.Example of how to use this is provided for the centroid fitter. Running the processor as-is uses DS::PMT information, as this is the default for most standard RAT experiments. To switch to Lognormal waveform analysis, use the following example snippet:
Should solve some structural issues with #220 #177