Fix a bug in waveform util #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llebanowski
reviewed
Dec 15, 2024
| // Make sure not to integrate past the end of the waveform | ||
| windowEnd = (windowEnd > waveform.size()) ? waveform.size() : windowEnd; | ||
| // Make sure not to integrate before the waveform starts | ||
| windowStart = (windowStart < 0) ? 0 : windowStart; | ||
|
|
||
| if (windowStart >= waveform.size()) { |
There was a problem hiding this comment.
Can have a more useful check now using windowEnd
|
@rpitelka take a look? |
|
Looks good to me! |
JamesJieranShen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check does not work when
windowStart < 0.if (windowStart >= waveform.size())