-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rattest QOL update + centroid test #214
Conversation
0e36e52
to
6b70f68
Compare
6b70f68
to
c20a0bd
Compare
My comments are all cosmetic, once @JamesJieranShen pushes the commits that fix the tests (and the tests pass) it looks good to me. I don't know what the removed files under |
heads up that actually the centroid test might fail -- there's actually a bug right now where the centroid fitter doesn't gracefully handle when total charge of the event is 0. This doesn't lead to a fail every single time, but does with certain seeds. |
We should have another PR to fix that bug that we can merge in at the same time as this PR. Are you able to do that @JamesJieranShen ? |
c20a0bd
to
6d26a33
Compare
will do! |
I don't understand the motivation for the generators selected to use in the macro. It seems like we're simulating three classes of events, which complicates understanding the output. I'd just simulate central, 5 MeV, isotropic electrons. We could have separate rattests for lower or higher energy events, if we choose. |
are you cool with just keeping the third one:
3.5-15MeV center runs? I'd think residual as a function of energy would be a useful thing. |
Sure, you'll need to update the analysis code accordingly. |
Test updated -- now we simulated 1000 electrons, from 3.5MeV to 15 MeV. We plot the overall distribution of the position distribution, as well as a profile of the residual as a function of energy. The test currently takes quite a while to run (about 15 minutes), due to the increased stats. If this is not necessary I can drop it down to perhaps 100events. |
Looks good to me. |
6b57a05
to
515b4a2
Compare
LGTM as well. |
* ignore test outputs * Install rattest to install/bin directly. * Add local / absolute experiment to ratdb path, mainly for testing purposes. * update documentation * (attempt to) revive fitcentroid test * add cformat to test scripts * remove old files * add basic ANSI color code for test output * move template back to workflow root * clean up fitcentroid code * add validity guard to fitcentroid test * update fitcentroid test to remove low energy runs
This PR includes the following QOL updates to rattest:
rattest.py
is now installed to${CMAKE_INSTALL_PREFIX}/bin
, alongside all other install executables.scintillator
material. Also added a inner detector volume to dramatically speedup simulation time.