Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set global RAT-PAC2 compile flag to -Wall -Werror #200

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

JamesJieranShen
Copy link
Contributor

... and also corresponding code changes that address the compile errors. Nothing should be substantial. Most errors are:

  • size_t vs int sign issues
  • unused variables
  • c string comparisons

src/gen/src/GLG4PosGen.cc Outdated Show resolved Hide resolved
src/gen/src/VertexGen_CRY.cc Outdated Show resolved Hide resolved
@tannerbk tannerbk self-assigned this Dec 2, 2024
@tannerbk
Copy link
Contributor

tannerbk commented Dec 2, 2024

Looks good.

@tannerbk
Copy link
Contributor

@JamesJieranShen can you push an empty commit to trigger the rattests?

@tannerbk tannerbk merged commit a33eb88 into rat-pac:main Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants