Companion changes for the Eos InHDF5Producer #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JamesJieranShen
commented
Jul 15, 2024
JamesJieranShen
commented
- Allow producers to be added in experiments built on top of ratpac2, such as EosSimulation.
- Fixes segfaults caused by OutNTuple when there are zero MC particles.
- Refactored and extended WaveformAnalysis:
- Allow it to take in different ratdb entries by specifying their indices.
- To allow for both Constant fraction discriminator and simple threshold timing
- Use the simple threshold timing to allow simple step-like traces coming from digitized triggers to be analyzed.
JamesJieranShen
force-pushed
the
feature/jierans-InHDF5Producer
branch
2 times, most recently
from
3990e3f to
b294fc6
Compare
JamesJieranShen
force-pushed
the
feature/jierans-InHDF5Producer
branch
from
b294fc6 to
caced32
Compare
JamesJieranShen
force-pushed
the
feature/jierans-InHDF5Producer
branch
from
e4164f0 to
b77cbfd
Compare
JamesJieranShen
force-pushed
the
feature/jierans-InHDF5Producer
branch
from
5eb5c40 to
1c541df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.