Add seperate branches in ntuple for MCPE frontend time and hit time #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesJieranShen
force-pushed
the
pr/ntuple-mcpetime
branch
from
41790b8 to
3a42c79
Compare
|
We can announce this on the next call and merge then. |
|
per comment by @gmwendel I've changed the name of the old branch to |
|
@tannerbk Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially breaking!
Old
mcPETimein ntuple is the time that front-end electronics see a detected photon, which includes timing effects of the PMT. This PR modifies this behavior such that the branchmcPETimenow records the time that a photon hits the PMT. The front-end time is written to a new branch namedmcPEFrontEndTime.Since this change assigns an old variable name to a new definition, previously-implemented analysis may need to be modified to account for it.