Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support both struct timespec and struct tm variants of the aon timer APIs #2079

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

kilograham
Copy link
Contributor

… since use of one type on RP2040 and the other on RP2350 require pulling in C library code.

Also provide weak pico_ wrappers for localtime_r and mktime so that the user can override the conversion functions

…APIs since use of one type on RP2040 and the other on RP2350 require pulling in C library code. Provide weak pico_ wrappers for localtime_r and mktime so that the user can override the conversion functions
@kilograham kilograham marked this pull request as draft November 21, 2024 02:24
@kilograham
Copy link
Contributor Author

fixes #1810

@kilograham kilograham added this to the 2.1.0 milestone Nov 21, 2024
@kilograham kilograham marked this pull request as ready for review November 22, 2024 01:01
peterharperuk
peterharperuk previously approved these changes Nov 22, 2024
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working ok and I can't spot any issues. Docs are much clearer now!

@kilograham kilograham merged commit 3dce58f into develop Nov 22, 2024
8 checks passed
@kilograham kilograham deleted the aon_timer_clib branch November 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants