Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent self-deadlock with PICOLIBC due to calloc/realloc internally calling malloc/free #2069

Merged
merged 2 commits into from
Nov 21, 2024
Merged

prevent self-deadlock with PICOLIBC due to calloc/realloc internally calling malloc/free #2069

merged 2 commits into from
Nov 21, 2024

Conversation

kilograham
Copy link
Contributor

We don't use a recusrive_mutex as we still want to cause a deadlock if an IRQ attempts a malloc within malloc. Therefore we track the IRQ nesting separately.

@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
@kilograham
Copy link
Contributor Author

fixes #1947

peterharperuk
peterharperuk approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense

@kilograham kilograham merged commit 08ea1d8 into develop Nov 21, 2024
8 checks passed
@kilograham kilograham deleted the picolibc_malloc_mutex branch November 21, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterharperuk peterharperuk peterharperuk approved these changes

@will-v-pi will-v-pi Awaiting requested review from will-v-pi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kilograham @peterharperuk