Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent early macro expansion in PICOBIN_..._AS_BITS() macros #2068

Merged
merged 2 commits into from
Nov 20, 2024
Merged

prevent early macro expansion in PICOBIN_..._AS_BITS() macros #2068

merged 2 commits into from
Nov 20, 2024

Conversation

kilograham
Copy link
Contributor

fixes #1974

@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
will-v-pi
will-v-pi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested with -DRP2350 compile option and it works fine

@kilograham kilograham merged commit 9a2b75e into develop Nov 20, 2024
8 checks passed
@kilograham kilograham deleted the embedded_block_defines branch November 20, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

@lurch lurch Awaiting requested review from lurch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kilograham @will-v-pi