Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making pio_calculate_clkdiv8_from_float round to the neareset 1/256 (not lower 1/256) #2063

Closed
wants to merge 1 commit into from

Conversation

kilograham
Copy link
Contributor

fixes #1931

@kilograham kilograham added this to the 2.1.0 milestone Nov 20, 2024
@lurch
Copy link
Contributor

lurch commented Nov 20, 2024

I'm afraid I'm not familiar enough with bit-manipulation / fixed-point arithmetic to know if this fix is correct, but it appears to match the suggestion in #1931 . Would a similar problem affect any of the other int_frac functions?

@lurch lurch removed their request for review November 20, 2024 01:49
@kilograham kilograham closed this Nov 20, 2024
@kilograham kilograham deleted the pio_clock_rounding branch November 20, 2024 01:49
@kilograham
Copy link
Contributor Author

kilograham commented Nov 20, 2024

this was superseded by #2065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants