Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow PICO_CORE1_STACK_SIZE=0 #2058

Merged
merged 2 commits into from
Nov 20, 2024
Merged

allow PICO_CORE1_STACK_SIZE=0 #2058

merged 2 commits into from
Nov 20, 2024

Conversation

kilograham
Copy link
Contributor

fixes #1803

@kilograham kilograham added this to the 2.1.0 milestone Nov 19, 2024
@kilograham kilograham changed the title allow PICO_CORE1_STACK_SIZE=9 allow PICO_CORE1_STACK_SIZE=0 Nov 19, 2024
@lurch
Copy link
Contributor

lurch commented Nov 19, 2024

Does this also need to modify https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_multicore/include/pico/multicore.h#L32 to allow min=0 ?

will-v-pi
will-v-pi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and have double checked it works. Although the use case of setting PICO_CORE1_STACK_SIZE to 0 and then allocating the stack on the fly throws no warnings with this, but didn't seem to throw warnings for me without this fix either even with -Wall

@kilograham kilograham merged commit c2118cc into develop Nov 20, 2024
8 checks passed
@kilograham kilograham deleted the zero_core1_stack_size branch November 20, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

@peterharperuk peterharperuk Awaiting requested review from peterharperuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kilograham @lurch @will-v-pi