Avoid hang in stdio_set_chars_available_callback #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is setting the callback after enabing the interrupt which can cause a hang if a receive character is already pending. Similarly we also have to clear the callback pointer only after the interrupt is disabled. Fixes raspberrypi#2009
peterharperuk
force-pushed
the
char_available_uart_hang_fix
branch
from
ad1622a to
3ceacfa
Compare
kilograham
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is setting the callback after enabing interrupts which can cause a hang if a receive character is already pending. Smilarly we also have to clear the callback pointer only after the interrupt is disabled.
Fixes #2009