Move cyw43 pin definitions #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Oct 10, 2024
It was probably not a good idea to put the default pin definitions in cyw43_configport.h as they're specific to pico_w and Micropython needs these but it has it's own version of cyw43_configport.h
peterharperuk
force-pushed
the
move_default_pin_defs
branch
from
ad915b8 to
c87d46f
Compare
|
...and yet |
kilograham
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was probably not a good idea to put the default pin definitions in cyw43_configport.h as they're specific to pico_w and Micropython needs these but it has it's own version of cyw43_configport.h