-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change div_int_frac methods to be suffixed by the number of bits of fraction e.g. div_int_frac8 #1926
Conversation
…act; e.g. div_int_frac8
…le future h/w change regresions
…uint32_t for future proofing
// PICO_CONFIG: CYW43_PIO_CLOCK_DIV_FRAC, Fractional part of the clock divider for communication with the wireless chip, type=bool, default=0, group=pico_cyw43_driver | ||
#ifndef CYW43_PIO_CLOCK_DIV_FRAC | ||
#define CYW43_PIO_CLOCK_DIV_FRAC 0 | ||
// PICO_CONFIG: CYW43_PIO_CLOCK_DIV_FRAC8, Fractional part of the clock divider for communication with the wireless chip 0-255, type=bool, default=0, group=pico_cyw43_driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're renaming the PICO_CONFIG:
entry from CYW43_PIO_CLOCK_DIV_FRAC
to CYW43_PIO_CLOCK_DIV_FRAC8
, we probably ought to do the same for the PICO_CMAKE_CONFIG:
entry at https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_driver/CMakeLists.txt#L87-L90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch; @peterharperuk since this value was new post SDK2.0 I'm not going to support the old value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I doubt there's much use for it anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably much use OF it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there's unlikely to be much need for changing the cyw43 pio divider by anything but a whole number.
@@ -48,7 +48,7 @@ void cyw43_driver_deinit(struct async_context *context); | |||
#define CYW43_PIO_CLOCK_DIV_DYNAMIC 0 | |||
#endif | |||
|
|||
// PICO_CONFIG: CYW43_PIO_CLOCK_DIV_INT, Integer part of the clock divider for communication with the wireless chip, type=bool, default=2, group=pico_cyw43_driver | |||
// PICO_CONFIG: CYW43_PIO_CLOCK_DIV_INT, Integer part of the clock divider for communication with the wireless chip, type=int, default=2, group=pico_cyw43_driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, how on earth did I miss this?? 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't spot any issues and my head hurts look at this change.
Looks like this change accidentally got omitted from #1926
Looks like this change accidentally got omitted from #1926
fixes #1924