Some small fixes/improvements for pico_minimize_runtime #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h PICO_PANIC_FUNCTION=
kilograham
force-pushed
the
minimize_runtime
branch
from
496e036 to
7a19850
Compare
lurch
reviewed
Sep 9, 2024
| @@ -65,7 +65,17 @@ endif() | |||
| # FLOAT - support for single-precision floating point | |||
| # DOUBLE - support for double-precision floating point | |||
| # FPGA_CHECK - checks for FPGA which allows Raspberry Pi to run your binary on FPGA | |||
| # PANIC - default panic impl which brings in stdio | |||
| # AUTO_INIT_MUTEX - auto init mutexes; without this you get no printf mutex either - | |||
There was a problem hiding this comment.
Is it worth mentioning/documenting "ALL" in this comment?
There was a problem hiding this comment.
probably; it needs better documentation anyway
There was a problem hiding this comment.
i'll add more documentation in a separate PR
peterharperuk
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.