Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lib instead of CMAKE_INSTALL_LIBDIR for pioasm install #1865

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

will-v-pi
Copy link
Contributor

The CMake GNUInstallDirs module prior to CMake version 3.23.1 used an architecture-specific CMAKE_INSTALL_LIBDIR on debian, which is not searched by find_package calls from the SDK

Fix this in the same way as picotool raspberrypi/picotool#117 by hard-coding the lib directory

@will-v-pi will-v-pi added this to the 2.0.1 milestone Aug 23, 2024
@will-v-pi will-v-pi requested a review from kilograham August 23, 2024 15:28
@lurch
Copy link
Contributor

lurch commented Aug 24, 2024

Fix this in the same way as picotool raspberrypi/picotool#117 by hard-coding the lib directory

For cross-reference porpoises 🐬 raspberrypi/picotool@6ad9c23

Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you

@kilograham kilograham merged commit dfb5738 into raspberrypi:develop Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants