Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extract configs #1845

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Update extract configs #1845

merged 5 commits into from
Aug 27, 2024

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Aug 19, 2024

Update config-extraction scripts to work with multiple chips
Associated fixes to the config-descriptions

@lurch lurch marked this pull request as draft August 19, 2024 11:21
@lurch
Copy link
Contributor Author

lurch commented Aug 19, 2024

Ooops broken the build, so I've converted to draft while I investigate.

@lurch
Copy link
Contributor Author

lurch commented Aug 19, 2024

Ooops broken the build, so I've converted to draft while I investigate.

Fixed!

@lurch lurch marked this pull request as ready for review August 19, 2024 11:39
@kilograham kilograham added this to the 2.0.1 milestone Aug 20, 2024
@kilograham
Copy link
Contributor

were you going to add a commit here, or separately?

@lurch
Copy link
Contributor Author

lurch commented Aug 22, 2024

were you going to add a commit here, or separately?

Up to you. You can either merge this PR as-is, so that I can then slide in my databooks PR that adds the tagging to the tables in chapters 5 and 6 of the Pico-SDK PDF, or you can leave this PR open until I've done the additional work to also tackle PICO_DEFINE (although I dunno when that'll happen yet, as I've been busy with other stuff).
EDIT: Ohhh!!! I've just realised that you were talking about the removal of "The..." from the start of the descriptions! 🤦‍♂️ I'm afraid I'd completely forgotten about that, I'll get that done this evening.

@lurch lurch self-assigned this Aug 22, 2024
@lurch lurch marked this pull request as draft August 22, 2024 18:07
@lurch lurch force-pushed the update_extract_configs branch from 08c00f7 to c3afa94 Compare August 26, 2024 16:30
@lurch lurch marked this pull request as ready for review August 26, 2024 16:32
@lurch
Copy link
Contributor Author

lurch commented Aug 26, 2024

were you going to add a commit here, or separately?

Now done - sorry I kept forgetting! 🤦‍♂️

@kilograham kilograham merged commit d639292 into develop Aug 27, 2024
2 checks passed
@kilograham kilograham deleted the update_extract_configs branch August 27, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants