Include Platform Paths files for the host #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes searching for installed picotool/pioasm on Windows, and generally improves default find_package behaviour
kilograham
approved these changes
Aug 15, 2024
will-v-pi
added a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Aug 19, 2024
This fixes searching for installed picotool/pioasm on Windows, and generally improves default find_package behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes searching for installed picotool/pioasm on Windows, and generally improves default find_package behaviour on Unix platforms too.
Without this some of the paths searched by find_package, such as
CMAKE_SYSTEM_PREFIX_PATH, will not be populated. See the find_package documentation for more details on how theCMAKE_SYSTEM_PREFIX_PATHis used when searching for installed packages (eg picotool/pioasm).