vcocalc.py improvements #1773
Closed
vcocalc.py improvements #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Jul 24, 2024
| refdiv_max = 63 | ||
|
|
||
| def validRefdiv(string): | ||
| if ((int(string) < refdiv_min) or (int(string) > refdiv_max)): |
There was a problem hiding this comment.
Only a minor nit, but I think personally I'd do the int(string) once, rather than three separate times?
lurch
reviewed
Jul 24, 2024
| if best[4] != 1: | ||
| print( | ||
| """ | ||
| As the requires a non-standard refdiv, this will |
There was a problem hiding this comment.
"As the requires" -> "As this requires" ?
lurch
reviewed
Jul 24, 2024
| )\ | ||
| """.format(best[4], int((args.input * 1_000_000) / best[4] * best[1]), best[2], best[3])) | ||
| else: | ||
| print("UNABLE TO COME UP WITH A SOLUTION....") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra check to match checks in check_sys_clock_khz, and add --lock-refdiv option to set fixed refdiv
Also add blurb to the output when a non-standard refdiv is required
Fixes #1665, and fixes #1451