Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake cmake_minimum_required Deprecation Warning #1546

Merged
merged 6 commits into from
Dec 15, 2023
Merged

CMake cmake_minimum_required Deprecation Warning #1546

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f29c80b
Update elf2uf2 CMakeLists.txt
galmyk Nov 13, 2023
981771b
Update pioasm CMakeLists.txt
galmyk Nov 13, 2023
5e588aa
Update top-level CMakeLists.txt
galmyk Nov 13, 2023
3921124
Update README.md
galmyk Nov 13, 2023
58c88d7
Update README.md
galmyk Nov 13, 2023
d4efead
Merge branch 'develop' into fix-cmake-minimum-required
kilograham Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.13)
cmake_minimum_required(VERSION 3.13...3.27)

# Note: this CMakeLists.txt can be used as a top-level CMakeLists.txt for the SDK itself. For all other uses
# it is included as a subdirectory via the pico_sdk_init() method provided by pico_sdk_init.cmake
Expand Down Expand Up @@ -61,4 +61,3 @@ if (NOT TARGET _pico_sdk_inclusion_marker)
pico_promote_common_scope_vars()
endif()
endif()

4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ instructions for other platforms, and just in general, we recommend you see [Ras
3. Setup a `CMakeLists.txt` like:

```cmake
cmake_minimum_required(VERSION 3.13)
cmake_minimum_required(VERSION 3.13...3.27)

# initialize the SDK based on PICO_SDK_PATH
# note: this must happen before project()
Expand All @@ -79,7 +79,7 @@ instructions for other platforms, and just in general, we recommend you see [Ras
1. Setup a `CMakeLists.txt` like:

```cmake
cmake_minimum_required(VERSION 3.13)
cmake_minimum_required(VERSION 3.13...3.27)

# initialize pico-sdk from submodule
# note: this must happen before project()
Expand Down
4 changes: 2 additions & 2 deletions tools/elf2uf2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.12)
cmake_minimum_required(VERSION 3.12...3.27)
project(elf2uf2)

set(CMAKE_CXX_STANDARD 14)
Expand All @@ -9,4 +9,4 @@ add_executable(elf2uf2 main.cpp)
if (WIN32 AND NOT MINGW AND (CMAKE_CXX_COMPILER_ID STREQUAL "Clang"))
target_compile_definitions(elf2uf2 PRIVATE _CRT_SECURE_NO_WARNINGS)
endif()
target_link_libraries(elf2uf2 boot_uf2_headers)
target_link_libraries(elf2uf2 boot_uf2_headers)
2 changes: 1 addition & 1 deletion tools/pioasm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.5...3.27)
project(pioasm CXX)

set(CMAKE_CXX_STANDARD 11)
Expand Down