added Xerxes RP2040 board to includes #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
approved these changes
Dec 15, 2023
mungewell
pushed a commit
to mungewell/pico-sdk
that referenced
this pull request
Mar 18, 2024
|
@theMladyPan I noticed (whilst working on #1814 ) that the #ifdef __cplusplus
}
#endif // __cplusplussection near the bottom of the file, but it doesn't have a corresponding |
|
dear @lurch Thank you for pointing out this problem. It looks like we forget to remove this code block after some cleanup. It is obviously a error on our side. Could you recommend how should I fix this? Open a new PR? |
|
Yes, opening a new PR would be best, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added header file for metrotech's xerxes board.
xerxes-rp2040 board is open source used to produce various IoT sensors.
Thank you in advance for considering this addition.