Skip to content

Commit

Permalink
Fixes #1891 Update pico_configure_ip4_address comments (#1892)
Browse files Browse the repository at this point in the history
* Update pico_configure_ip4_address comments

Update pico_configure_ip4_address CMakeLists.txt function comments to correct compile definition names

* Swap compile definitions in comments

Swap compile definitions order in pico_configure_ip4_address to group more naturally.
  • Loading branch information
mattmyne authored Sep 28, 2024
1 parent 78533ec commit ff373b3
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/rp2_common/pico_cyw43_driver/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,13 @@ if (EXISTS ${PICO_CYW43_DRIVER_PATH}/${CYW43_DRIVER_TEST_FILE})
# Set an ip address in a compile definition
# target name, target type, compile definition name to set then address in a string
# This can be used to set the following compile definitions
# CYW43_DEFAULT_IP_ADDRESS
# CYW43_DEFAULT_IP_STA_ADDRESS
# CYW43_DEFAULT_IP_STA_GATEWAY
# CYW43_DEFAULT_IP_AP_ADDRESS
# CYW43_DEFAULT_IP_AP_GATEWAY
# CYW43_DEFAULT_IP_MASK
# CYW43_DEFAULT_IP_GATEWAY
# CYW43_DEFAULT_IP_DNS
# CYW43_DEFAULT_AP_IP_ADDRESS
# e.g. pico_configure_ip4_address(picow_tcpip_server_background PRIVATE CYW43_DEFAULT_IP_ADDRESS "10.3.15.204")
# e.g. pico_configure_ip4_address(picow_tcpip_server_background PRIVATE CYW43_DEFAULT_IP_STA_ADDRESS "10.3.15.204")
function(pico_configure_ip4_address TARGET_LIB TARGET_TYPE DEF_NAME IP_ADDRESS_STR)
string(REGEX MATCHALL "[0-9]+" IP_ADDRESS_LIST ${IP_ADDRESS_STR})
list(LENGTH IP_ADDRESS_LIST IP_ADDRESS_COMPONENT_COUNT)
Expand Down

0 comments on commit ff373b3

Please sign in to comment.