This repository has been archived by the owner on Nov 22, 2017. It is now read-only.
Optimize timezone calculation and fix content type of timezone.js #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Fix bug of #timeto in #graphheader div * Add missing semicolons * Deleting trailing whitespace
Conflicts: static/lib/js/shared.js
|
Hi ! I have tested your changes in my environment. Everything is now good for the research, except for the stream part. In the stream part, the time is wrong displayed (my timezone is CEST and time displayed is CEST + 1 hour). Do you have an idea of what goes wrong ? Thanks ! |
|
OK, I'll check it in the following days. |
Conflicts: public/lib/js/ajax.js
Conflicts: lib/kibana-app.rb public/lib/js/ajax.js public/lib/js/stream.js
|
Can we get this pulled in, please? Right now I'm having to locally work around the content-type bug, which is icky. |
|
@apeiron I manually committed the content-type fix yesterday. However that line is only one of the 200 changed by this pull. This pull will require extensive review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.ltOffsetto store delta between target timezone and timezone of browser envwindow.ltOffsetto render time of target timezoneCustomtimeframe is selectedapplication/javascript