Initial refactor - much better types #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rasheedja
commented
Jul 14, 2023
•
rasheedja
commented
- Use types which are way clearer
- Some docs
- Use lens where they make things easier
- New types required quite a significant factor of the codebase
- Cleanup
- Further refactoring/polishing
- I want type names to reflect those typically used when talking about simplex methods
- But first, I need to learn what the actual terms are
- I'd also like to simplify a lot of these functions
- The refactor has made it easier for me to think about these functions, which makes it easier to simplify them
+ Use types which are way clearer
+ Some docs
+ Use lens where they make things easier
+ New types required quite a significant factor of the codebase
+ TODO:
+ Cleanup
+ Further refactoring/polishing
+ I want type names to reflect those typically used when talking about simplex methods
+ But first, I need to learn what the actual terms are
+ I'd also like to simplify a lot of these functions
+ The refactor has made it easier for me to think about these functions, which makes it easier to simplify them
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
5488f38
to
d8f1929
Compare
+ test10 was broken due to an LLM sneakily adding extra constraints and changing objective + testQuickCheck1/2 were broken because the constraints were built using `Map.fromList` with duplicate keys + only one of the key values were used, others were ignored
+ Control.Monad.Logger used for logging + Documented various functions + Handled some edge cases which shouldn't be possible (and log warnings/errors when we reach these edge cases)
+ I like this name better + Allows for alternative solvers
+ I was using the cabal plan as a key, now I use stack files/cabal generated files
+ Don't want to spend effor fixing windows caching
rasheedja
force-pushed
the
junaidr/refactor-types
branch
from
e287894
to
8625413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.