Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce Pober+2014 results #82

Merged
merged 22 commits into from
Aug 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
39d986d
test: reproduce Pober+2014 results
steven-murray Oct 4, 2022
3f8c19a
maint: remove useless file
steven-murray Oct 4, 2022
48aa302
fix: remove forced error
steven-murray Oct 4, 2022
60dba03
fix: use correct latitude for P14
steven-murray Nov 3, 2022
b2b1120
docs: small changes
steven-murray Jun 2, 2023
e31eda6
fix: _average_sense_to_1d was dropping half the bins
jpober Jul 7, 2023
ed064e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 7, 2023
efea9d5
docs: fix reproducing_pober notebook
steven-murray Jul 14, 2023
665bfb3
style: update pre-commit
steven-murray Jul 14, 2023
ddff19f
test: relax stringency on longest baseline
steven-murray Jul 14, 2023
e781fe4
docs: use furo theme
steven-murray Jul 14, 2023
120c53f
docs: compare correct SNR's in pober14 test
steven-murray Jul 14, 2023
fb8177c
refactor: don't use COSMO from config
steven-murray Jul 21, 2023
1a1ffce
docs: update descriptions of some parameter settings
steven-murray Jul 25, 2023
6d676fb
fix: quantity_input not working well
steven-murray Jul 25, 2023
c5ea9d8
fix: use pyuvdata>=2.4.0
steven-murray Jul 26, 2023
1aa77fc
style: remove unnecessary imports
steven-murray Jul 26, 2023
897d501
perf: faster finding of redundancies
steven-murray Jul 26, 2023
eb62a79
test: add required file for doc test
steven-murray Jul 27, 2023
2892e2f
docs: move docs data
steven-murray Jul 27, 2023
6d821b5
fix: properly hickle-write for cosmo
steven-murray Jul 27, 2023
a1d232c
test: add tests of approximate conversions
steven-murray Jul 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ ignore =
W503
F403
F401
D401 # Imperative mood -- doesn't work for cached-property.
N802 # TODO: remove this (function name should be lower-case)
B019 # no using lru_cache on methods
G004 # logging uses f-string
D107 # no docstring in __init__
# Imperative mood -- doesn't work for cached-property.
D401
# TODO: remove this (function name should be lower-case)
N802
# no using lru_cache on methods
B019
# logging uses f-string
G004
# no docstring in __init__
D107
max-line-length = 88
max-complexity = 18
rst-roles =
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/run-docs-code.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
demo: ["getting_started", "understanding_21cmsense"]
demo: ["getting_started", "understanding_21cmsense", "reproducing_pober_2015"]
steps:
- uses: actions/checkout@master
with:
Expand All @@ -27,7 +27,7 @@ jobs:
mamba-version: "*"
channels: conda-forge,defaults
channel-priority: true
python-version: ${{ matrix.python-version }}
python-version: "3.10"
environment-file: ci/${{ env.ENV_NAME }}.yaml
activate-environment: ${{ env.ENV_NAME }}

Expand All @@ -50,6 +50,7 @@ jobs:
papermill -k sense docs/tutorials/${{ matrix.demo }}.ipynb output-${{ matrix.demo }}.ipynb

- uses: actions/upload-artifact@v3
if: always()
with:
name: ${{ matrix.demo }}
path: output-${{ matrix.demo }}.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/test-with-warnings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest]
python-version: ["3.10"]
steps:
- uses: actions/checkout@master
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testsuite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest]
python-version: [3.9, "3.10"]
steps:
- uses: actions/checkout@master
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ cython_debug/
pip-wheel-metadata/
.tox/
*.pkl
*.npz
*.png
.vscode/
*MHz.h5
Expand Down
12 changes: 6 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ exclude: '^docs/conf.py'

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.2.0
rev: v4.4.0
hooks:
- id: trailing-whitespace
- id: check-added-large-files
Expand All @@ -17,7 +17,7 @@ repos:
args: ['--fix=no']

- repo: https://github.com/PyCQA/flake8
rev: 4.0.1
rev: 6.0.0
hooks:
- id: flake8
additional_dependencies:
Expand All @@ -39,22 +39,22 @@ repos:


- repo: https://github.com/psf/black
rev: 22.3.0
rev: 23.7.0
hooks:
- id: black

- repo: https://github.com/PyCQA/isort
rev: 5.10.1
rev: 5.12.0
hooks:
- id: isort

- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.9.0
rev: v1.10.0
hooks:
- id: rst-backticks

- repo: https://github.com/asottile/pyupgrade
rev: v2.32.0
rev: v3.9.0
hooks:
- id: pyupgrade
args: [--py38-plus]
5 changes: 1 addition & 4 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,8 @@
"issue": ("https://github.com/steven-murray/21cmSense/issues/%s", "#"),
"pr": ("https://github.com/steven-murray/21cmSense/pull/%s", "PR #"),
}
# on_rtd is whether we are on readthedocs.org
on_rtd = os.environ.get("READTHEDOCS", None) == "True"

if not on_rtd: # only set the theme if we're building docs locally
html_theme = "sphinx_rtd_theme"
html_theme = "furo"

html_use_smartypants = True
html_last_updated_fmt = "%b %d, %Y"
Expand Down
3 changes: 2 additions & 1 deletion docs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ dependencies:
- pandoc
- pip
- python=3.10
- sphinx_rtd_theme
- setuptools_scm
- pip:
- furo
1 change: 1 addition & 0 deletions docs/tutorials.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ The following introductory tutorials will help you get started with ``21cmSense`
tutorials/getting_started
tutorials/understanding_21cmsense
tutorials/cli_tutorial
tutorials/reproducing_pober_2015
469 changes: 469 additions & 0 deletions docs/tutorials/reproducing_pober_2015.ipynb

Large diffs are not rendered by default.

Loading
Loading