Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff formating, support numpy 2 #126

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add ruff formating, support numpy 2 #126

merged 3 commits into from
Jun 27, 2024

Conversation

steven-murray
Copy link
Contributor

This adds ruff formatting, and also fixes support for numpy 2.0 (except that it depends on pyuvdata which is not compatible yet).

updates:
- [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.59%. Comparing base (2a7e64e) to head (ea138c8).
Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
src/py21cmsense/observation.py 88.88% 1 Missing ⚠️
src/py21cmsense/observatory.py 92.30% 1 Missing ⚠️
src/py21cmsense/sensitivity.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   98.61%   98.59%   -0.02%     
==========================================
  Files          15       15              
  Lines        1081     1066      -15     
==========================================
- Hits         1066     1051      -15     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I have one small question. Beyond that, it's apparently upset about 3 lines not being covered 😆

src/py21cmsense/conversions.py Show resolved Hide resolved
Copy link
Contributor

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦮

@mkolopanis mkolopanis merged commit 75c55ec into main Jun 27, 2024
29 of 31 checks passed
@mkolopanis mkolopanis deleted the addruff branch June 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants