Merge pull request #29 from rarimo/fix/bugs

Fix auth in create balance. Fix points and level accruing after claim.
rarimo · Jun 18, 2024 · a811cbc · a811cbc
2 parents 61017df + 0717dc8
commit a811cbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/internal/service/handlers/claim_event.go b/internal/service/handlers/claim_event.go
@@ -165,8 +165,6 @@ func DoClaimEventUpdates(
 		if err = referralsQ.New().Insert(refToAdd...); err != nil {
 			return fmt.Errorf("failed to insert referrals: %w", err)
 		}
-
-		return nil
 	}
 
 	err = balancesQ.FilterByNullifier(balance.Nullifier).Update(map[string]any{

diff --git a/internal/service/handlers/create_balance.go b/internal/service/handlers/create_balance.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"net/http"
 
+	"github.com/rarimo/decentralized-auth-svc/pkg/auth"
 	"github.com/rarimo/rarime-points-svc/internal/data"
 	"github.com/rarimo/rarime-points-svc/internal/data/evtypes"
 	"github.com/rarimo/rarime-points-svc/internal/service/requests"
@@ -21,6 +22,11 @@ func CreateBalance(w http.ResponseWriter, r *http.Request) {
 
 	nullifier := req.Data.ID
 
+	if !auth.Authenticates(UserClaims(r), auth.UserGrant(nullifier)) {
+		ape.RenderErr(w, problems.Unauthorized())
+		return
+	}
+
 	balance, err := BalancesQ(r).FilterByNullifier(nullifier).Get()
 	if err != nil {
 		Log(r).WithError(err).Error("Failed to get balance by nullifier")