Drop void
return type when raising exceptions
#436
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435
After poking at this a bit locally, it seems Cython's
except *
is picking up exceptions set throughasyncio
even when it shouldn't. Not sure if this behavior is due to Python or Cython. That said, we can avoid usingexcept *
here by usingcdef
without thevoid
return type (this is the same ascdef object
). Based on running things locally this seems to behave correctly for me. Though please check as well.