Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PyNVML 12 #1100

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Use PyNVML 12 #1100

merged 1 commit into from
Dec 20, 2024

Conversation

jakirkham
Copy link
Member

Bump pynvml from 11 to 12. This version of pynvml also now depends on nvidia-ml-py for core functionality.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 19, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jakirkham jakirkham requested a review from rjzamora December 19, 2024 04:21
@jakirkham
Copy link
Member Author

/ok to test

@jakirkham jakirkham marked this pull request as ready for review December 20, 2024 07:35
@jakirkham jakirkham requested a review from a team as a code owner December 20, 2024 07:35
@jakirkham jakirkham requested a review from AyodeAwe December 20, 2024 07:35
jameslamb
jameslamb approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, based on my understanding of gpuopenanalytics/pynvml#57

pentschev
pentschev approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jakirkham

@jakirkham
Copy link
Member Author

Thanks James and Peter! 🙏

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f8e34c3 into rapidsai:branch-0.42 Dec 20, 2024
42 checks passed
@jakirkham jakirkham deleted the use_pynvml_12 branch December 20, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@pentschev pentschev pentschev approved these changes

@rjzamora rjzamora Awaiting requested review from rjzamora

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
improvement non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @pentschev @jameslamb