remove unnecessary sccache configuration, other small CI changes #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
5 - DO NOT MERGE
jameslamb
commented
Oct 29, 2024
jameslamb
changed the title
jameslamb
changed the title
msarahan
approved these changes
Oct 29, 2024
jameslamb
commented
Oct 29, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#111
Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.
rapids-dependency-file-generator(v1.16.0)rapids-configure-sccache(this project does not usesccache)Notes for Reviewers
I'd originally started this PR with the goal of printing
sccachestats in builds here... but realized this project does not usesccache.I chose not to pursue adding
sccachehere. The fact that this project doesn't use CMake means it'd take some effort to figure out how to injectsccacheinto the compilation (CC/CXXenvironment variables? something else?). Conda and wheel builds are only spending around 20 seconds actually compiling Cython code, so it doesn't seem worth the effort.